docs(2-bm): fold the channel-cut energy-calibration answer (ENERGY-7)#300
Merged
Conversation
Staff confirmed (ENERGY-7, #256) that channel-cut crystal energy calibration is current 2-BM practice: a removable reference crystal (36 x 3 mm, 2d = 3.84 angstrom, consistent with Si(220)) mounted on the sample rotation stage in place of the sample, rocked through its Bragg peak to recover the true beam energy. CORA already models the operation (the energy_characterization Procedure + the crystal as a calibration Subject). This folds the confirmation: - adds the missing energy_characterization Method to the catalog (capability characterization; it was referenced by the site practice but absent from catalog.yaml); - drops pending on the 2BM_energy_characterization_practice (confirmed current practice); - records the crystal identity (Si(220), 2d, dimensions, removable) in the procedures Energy section. Leaves ENERGY-7 OPEN on a residual the answer surfaced: it names the rocking stage as an Aerotech ABRS-150MP, but CORA's Rotary is an ABRS-250MP (datasheet-confirmed, #164). Reframed the question row to that stage-model confirm plus explicit Si(220) and re-run cadence, rather than silently overriding the well-sourced 250MP. Addresses ENERGY-7 (#256). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds the ENERGY-7 staff answer (#256).
What
Staff confirmed channel-cut crystal energy calibration is current 2-BM practice: a removable reference crystal (36 x 3 mm, 2d = 3.84 Å, consistent with Si(220)) mounted on the sample rotation stage in place of the sample.
CORA already models the operation (the
energy_characterizationProcedure + the crystal as a calibration Subject), so this folds the confirmation:energy_characterizationMethod tocatalog.yaml(it was referenced by the site practice but absent from the catalog);pendingon2BM_energy_characterization_practice;Why it stays open
The answer surfaced a discrepancy worth confirming rather than silently folding: it names the rocking stage as an Aerotech ABRS-150MP, but CORA's
Rotaryis an ABRS-250MP (datasheet-confirmed, #164). I reframed the ENERGY-7 question row to that stage-model confirm (plus explicit Si(220) and re-run cadence) and left #256 open on it.Tests
tests/unit/deployments/(62, catalog + site referential integrity) +test_2bm_energy_characterization.py+mkdocs --strictall green.Addresses ENERGY-7 (#256).
🤖 Generated with Claude Code