Repository navigation
fix(core): start a new connection on the TLS mode the engine's own client uses - #4051
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
November 5, 2026 07:35
datlechin
disabled auto-merge
November 5, 2026 08:14
# Conflicts: # core/ARCHITECTURE.md # core/docs/decisions/README.md
# Conflicts: # core/crates/core/src/capabilities.rs # core/crates/drivers/cassandra/src/session.rs # core/crates/drivers/clickhouse/src/endpoint.rs # core/crates/drivers/mongodb/src/endpoint.rs # core/crates/drivers/postgres/src/errors.rs # core/crates/drivers/postgres/src/physical.rs # core/crates/ffi/src/connection_url.rs # core/docs/decisions/README.md
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TlsMode::Prefer(tokio-postgresSslMode::Prefer, sqlxPreferred, certificate not checked),TlsCapabilities::default_modeandtls_ports,DriverCapabilities::new_connection_tls.ServerRefusedTlsnow does on Linux and Windows.ServerRequiresTlswhen it completes.ServerNameOverride.prefer,allow,PREFERRED,mongodb+srv://and the trust-any-certificate flags.Screenshots
A new PostgreSQL connection's Security group on Linux, before and after.
Windows, from the UI tests on Arm64 (main's last run before, this PR's after): a new MySQL connection, then a new SQL Server connection.
Test plan
a_new_connection_starts_on_the_mode_the_engines_own_client_starts_on, corea_new_connection_starts_on_the_engines_default_and_a_seed_list_or_tls_port_on_verify_full, Linuxtls_remedya_server_without_tls_offers_the_encryption_row, the Linux form and dialog follow tests, WindowsConnectionDraftTestsandTlsRemedyTests.verify_full_is_default(now per engine),encryption_combo_lists_only_capability_modesand the submit test's mode, the foreign-import Preferred cases, the Redis, MongoDB, Cassandra and ClickHouseplaintext_rejection_category, the PostgreSQL and MySQL capability tests, and the Windows draft fixtures.