set & handle etags/if-none-match for first rustdoc assets #3006
Merged
Conversation
b0abca9 to
9a9dfc1
Compare
This was referenced Nov 22, 2025
fd1801a to
b951647
Compare
6e73ef0 to
b1afdd1
Compare
Member
Author
|
@GuillaumeGomez have you seen this one here? |
GuillaumeGomez
approved these changes
Nov 25, 2025
Member
|
Now I did. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step towards #1560.
Idea is:
The next step after is trying to figure out an etag for rustdoc pages, which finally could give us the gains laid out in #1560 .
I feel like there is also some duplication around conditional-get handling, but I want to see the rustdoc part first before I start reducing the duplication.
I changed the format of the
Last-Modifiedheader too, it looks like usingUTCis against RFC, andGMTwould be correct.