chore: use reusable gitops-validate workflow#139
Merged
Conversation
Replace the hand-maintained validate.yaml + basic.yml with a thin caller to the new giantswarm/github-workflows/.github/workflows/gitops-validate.yaml reusable. Behaviour is unchanged; the action pins are now maintained centrally and on current node24 releases, clearing the Node 20 / set-output deprecation warnings. basic.yml is dropped as redundant — its yamllint is already an --all-files pre-commit hook (adrienverge/yamllint). The caller references the reusable at @feat/gitops-validate for verification; it will be switched to @main once github-workflows#233 merges. Relates to giantswarm/roadmap#4121. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 task
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-workflows#233 is merged; switch the caller from the verification branch to @main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No semantic YAML differences in changed source files. (Key reordering without value changes is ignored.) Suppress with |
Validation output log |
Rendered manifest diff output log |
uvegla
approved these changes
Jul 2, 2026
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the two hand-maintained CI workflows (
validate.yaml+basic.yml) with a thin caller to the new reusable giantswarm/github-workflows#233 (gitops-validate.yaml).Behaviour is unchanged — same four jobs (pre-commit,
./tools/test-all-ff validate, rendered-manifestdyffcomment,tests/atskind e2e) — but the GitHub Actions pins now live ingithub-workflows, maintained centrally on current node24 releases, which clears the Node 20 andset-outputdeprecation warnings that this repo's CI was emitting.basic.ymlis deleted as redundant: its only step is yamllint, which is already an--all-filespre-commit hook (adrienverge/yamllint) run bycheck-pre-commit.Verification
...gitops-validate.yaml@feat/gitops-validateso this PR's run verifies the reusable end-to-end before it merges. Once #233 is merged I'll switch the pin to@main.Expectations on this PR's run:
check-pre-commit,validate,get-diffpass and post their usual comments; no Node20/set-output warnings.test_on_kindstill fails at theapptestctlbootstrap step — a pre-existing breakage (missing PodMonitor/VPA CRDs), unrelated to this change; see roadmap#4121. Its failure reason should be unchanged from before.Relates to giantswarm/roadmap#4121.
🤖 Generated with Claude Code