Drop key-ordering enforcement from .yamllint#140
Merged
Conversation
The alphabetical key-ordering rule only existed to keep PR diffs readable. The yaml-diff bot (calling giantswarm/github-workflows yaml-diff.yaml) now posts clean semantic diffs that ignore key reordering, so enforcing key order is no longer necessary and is an unexpected restriction for users. Closes giantswarm/roadmap#4121. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 2, 2026
|
No semantic YAML differences in changed source files. (Key reordering without value changes is ignored.) Suppress with |
This was referenced Jul 2, 2026
Validation output log |
Rendered manifest diff output log |
mproffitt
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of giantswarm/roadmap#4121 — removes the alphabetical
key-orderingrule from.yamllint.That rule only ever existed to keep PR diffs readable, at the cost of forcing an unnatural key order on Kubernetes resources. Now that the
yaml-diffbot posts clean semantic diffs on every PR (ignoring key reordering, verified over Phase 1), the restriction is no longer needed.key-orderingwas the only rule this config enabled, so yamllint now enforces nothing (SOPS/.github/pre-commit ignores unchanged). This is a one-line revert if anything surprises us.Closes #4121.
🤖 Generated with Claude Code