Repository navigation
telemetry [14]: remove asset_id - #779
Open
bfjelds (bfjelds) wants to merge 1 commit into
Open
bfjelds (bfjelds) wants to merge 1 commit into
bfjelds (bfjelds) wants to merge 1 commit into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Sep 4, 2026
bfjelds (bfjelds)
changed the title
| --filepath "$METRICS_FILE" \ | ||
| --mapping "$KUSTO_TABLE_MAPPING" | ||
| --mapping "$KUSTO_TABLE_MAPPING" \ | ||
| --ignore-schema |
Member
Author
There was a problem hiding this comment.
adding ignore-schema because we removed asset_id which is a required field in the telemetry schema.
other options would be:
- remove asset_id from required list in schema
- use asset_id as installation_id
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
2 times, most recently
from
September 5, 2026 01:36
1599407 to
c96c0af
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Install finalization overwrites the staged servicing ID, breaking cross-invocation correlation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates telemetry identifiers to improve privacy and correlate servicing operations across invocations.
Changes:
- Removes hardware-derived
asset_idand renamescorrelation_idtoinstallation_id. - Persists and emits per-servicing-operation
servicing_idvalues. - Adjusts telemetry documentation and Kusto ingestion.
File summaries
| File | Description |
|---|---|
docs/Reference/Agent-Configuration.md |
Documents telemetry identifiers. |
crates/trident/src/main.rs |
Passes the installation-ID handle to App Insights. |
crates/trident/src/logging/tracestream.rs |
Emits installation and servicing IDs. |
crates/trident/src/logging/operation_context.rs |
Tracks servicing IDs per invocation. |
crates/trident/src/logging/appinsights.rs |
Adds identifiers to App Insights events. |
crates/trident/src/lib.rs |
Creates and restores identifiers during servicing. |
crates/trident/src/engine/update.rs |
Creates servicing IDs for updates. |
crates/trident/src/engine/manual_rollback/mod.rs |
Handles rollback servicing IDs. |
crates/trident/src/datastore.rs |
Persists installation and servicing IDs. |
.pipelines/templates/stages/testing_common/scripts/upload_metrics.sh |
Uploads metrics without schema validation. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 5, 2026 16:31
c96c0af to
bcab5b0
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Servicing IDs are assigned before rollback eligibility is known and are not restored for post-reboot commit metrics.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Balanced
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 5, 2026 17:02
bcab5b0 to
941e873
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The core servicing-ID serialization path lacks sink-level regression coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 1
- Review effort level: Balanced
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 5, 2026 19:58
941e873 to
6f8944b
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The updated diff addresses the prior lifecycle and serialization gaps, with no remaining blocking correctness issues found.
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 0 new
- Review effort level: Balanced
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/installation-servicing-id
branch
from
September 5, 2026 20:41
6f8944b to
7256f43
Compare
This was referenced Oct 26, 2026
This was referenced Oct 30, 2026
Rebase onto agent configuration read-error handling. Original layer head: c7313c8 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
At
c7313c8d4bef4b2d0a96f08d6f80314f2513b302on 2026-10-30:cargo fmt -- --check: passed.-D warnings): passed withgrpc-preview,dangerous-options,trident_api/documentation,functional-test,pytest-generator.functional-test.Stack
Native stack 913, position 14/20. Positions 1-14 provide sink-neutral telemetry; positions 15-20 add telemetry preferences, shared transport, AppInsights and build/image/package integration.
Full-stack pipeline branch:
user/bfjelds/telemetry-default-optin(#910).Related PRs in stack: