[bfjelds (bfjelds)]

Description

Add rollback-start and runtime/streaming success metrics; archive runtime outcomes after reporting errors or success.

Rationale

Extracted from #778 to make the telemetry stack easier to review. Combined changes are unchanged.

Validation

Source	Command or check	Result	Notes
Agent	cargo test --locked --manifest-path /home/bfjelds/mjolnir-sandbox/trident-telemetry-split778-20261025-1743/Cargo.toml -p trident -p osutils -p trident_api --features trident/grpc-preview,trident/dangerous-options,trident_api/documentation -- command_kind:: logging:: cli:: engine::context:: config::host::tests virt::	Passed	115 targeted unit tests; run from /home/bfjelds/mjolnir-sandbox.
Agent	Git tree comparison	Passed	Final split tip exactly matches original #778; restacked #779/#781 trees unchanged.
Agent	VM functional tests	Not run	Require a VM; only host-safe unit tests were run.
CI	Pipeline checks	Not run	Not evaluated as part of this split; results above are local.

Related PRs in stack:

• telemetry [1]: add generic key-value storage to datastore #773
• telemetry [2]: introduce typed command classification #880
• telemetry [3]: correlate commands with operation context #881
• telemetry [4]: persist and attach installation IDs #882
• telemetry [5]: correlate staged servicing operations #883
• telemetry [6]: add agent configuration opt-in #884
• telemetry [7]: share background upload transport #885
• telemetry [8]: send metrics to Application Insights #774
• telemetry [9]: configure telemetry ingestion destinations #886
• telemetry [10]: enrich platform and startup metrics #888
• telemetry [11]: report effective servicing feature usage #889
• telemetry [12]: preserve local metrics and bound TraceStream requests #890
• telemetry [13]: introduce command error reporting helpers #778
• telemetry [14]: report CLI and reboot command failures #891
• telemetry [15]: report daemon dispatch and request errors #892
• telemetry [16]: report gRPC client transport failures #893
• [this PR] telemetry [17]: complete servicing outcome metrics #894
• telemetry [18]: remove asset_id #779
• telemetry [19]: enable Telemetry=OptIn by default for test/dev images #781

[azure-pipelines]

Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

🟡 Changes recommended

No-op rollback requests emit unmatched start events, incorrectly counting rollbacks that never begin.

1 open issue

• Emit rollback start event only after selecting a rollback target · New

What changed in this PR

Completes servicing outcome telemetry in Trident’s telemetry stack by adding success signals and archiving runtime metrics after outcomes are reported.

Changes:

• Adds streamed-install, runtime-update, and runtime-rollback success metrics.
• Adds manual-rollback start telemetry and request-kind debug support.
• Moves runtime-update metric archival after success or error reporting.

File	Description
crates/​trident/​src/​lib.rs	Reports streamed-install success.
crates/​trident/​src/​engine/​runtime_update.rs	Reports runtime outcomes before archiving metrics.
crates/​trident/​src/​engine/​manual_rollback/​utils.rs	Derives traits used by rollback request telemetry.
crates/​trident/​src/​engine/​manual_rollback/​mod.rs	Adds rollback-start and runtime-rollback success metrics.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

The focused telemetry changes preserve servicing behavior, resolve the prior no-op reporting issue, and have no identified blocking issues.

No open issues 🎉

1 resolved since last review

• Emit rollback start event only after selecting a rollback target

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No blocking issues remain in outcome reporting or archive ordering, and the previously reported no-op rollback issue is resolved.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues remain for the servicing outcome metrics changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are identified for the servicing outcome telemetry changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues remain for the servicing outcome telemetry changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are recorded for the servicing telemetry changes.

No open issues 🎉

_{Review effort: Balanced}