Repository navigation
telemetry [7]: share background upload transport - #885
Draft
bfjelds (bfjelds) wants to merge 1 commit into
Draft
bfjelds (bfjelds) wants to merge 1 commit into
bfjelds (bfjelds) wants to merge 1 commit into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 25, 2026
bfjelds (bfjelds)
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The changed log exclusion allows uploader shutdown records to produce misleading upload-failure messages after successful shutdown.
1 open issue
What changed in this PR
This PR extracts shared upload infrastructure for log forwarding and the upcoming telemetry uploader, while keeping queue policies separate.
Changes:
- Centralizes HTTP transport, response validation, redirect protection, and per-origin cooldowns.
- Shares uploader thread startup and deadline-based shutdown helpers.
- Updates upload APIs, exports, call sites, and tests.
| File | Description |
|---|---|
crates/trident/src/logging/upload_core.rs |
Adds shared transport, cooldown, lifecycle helpers, and tests. |
crates/trident/src/logging/mod.rs |
Registers the shared upload module. |
crates/trident/src/logging/logstream.rs |
Passes the new optional content-type argument. |
crates/trident/src/logging/background_uploader.rs |
Uses shared helpers and adds validation and shutdown APIs. |
crates/trident/src/lib.rs |
Exports BackgroundUploadHandle for reuse. |
Review effort: Balanced
This was referenced Oct 26, 2026
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-upload-core
branch
from
October 26, 2026 01:33
0864c0e to
67b9659
Compare
bfjelds (bfjelds)
changed the title
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-upload-core
branch
from
October 26, 2026 01:53
67b9659 to
c873769
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-upload-core
branch
from
October 28, 2026 00:06
c873769 to
c4968cc
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-upload-core
branch
from
October 28, 2026 20:45
c4968cc to
92597ad
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0e7cadc-8f44-443f-affe-6ce8e856a218 Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-upload-core
branch
from
October 28, 2026 21:58
92597ad to
6167a5b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract transport, response validation, cooldown, and shutdown helpers for reuse.
Related PRs in stack: