Repository navigation
telemetry [6]: enrich platform and startup metrics - #912
Draft
bfjelds (bfjelds) wants to merge 1 commit into
Draft
bfjelds (bfjelds) wants to merge 1 commit into
bfjelds (bfjelds) wants to merge 1 commit into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 26, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The telemetry documentation misstates metrics retention and diagnose behavior, and incorrectly implies journald output includes enriched records’ metadata and correlation IDs.
2 open issues
What changed in this PR
Enriches Trident’s telemetry with host details and boot uptime, while sharing virtualization detection with diagnostics.
Changes:
- Adds VM, architecture, and ACL metadata to telemetry records.
- Reports boot uptime on
trident_start, with a best-effort fallback. - Documents telemetry outputs and correlation-ID lifecycles.
| File | Description |
|---|---|
docs/Reference/Telemetry.md |
Documents local outputs, metadata, and correlation IDs. |
crates/trident/src/logging/tracestream.rs |
Adds host metadata, uptime conversion, and tests. |
crates/trident/src/lib.rs |
Includes boot uptime in the startup metric. |
crates/trident/src/diagnostics.rs |
Reuses shared hypervisor detection. |
crates/osutils/src/virt.rs |
Provides shared DMI-based virtualization helpers. |
Cargo.toml |
Enables nix clock APIs through the time feature. |
Review effort: Balanced
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-platform-startup
branch
from
October 30, 2026 17:07
5e78b22 to
36d16d8
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-platform-startup
branch
from
October 30, 2026 18:24
36d16d8 to
2c3f034
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-platform-startup
branch
from
October 30, 2026 20:14
2c3f034 to
5ccfa42
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-platform-startup
branch
from
October 30, 2026 20:46
5ccfa42 to
03b334e
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-platform-startup
branch
from
October 30, 2026 22:02
03b334e to
2e45b1c
Compare
Rebase onto agent configuration read-error handling. Apply approved telemetry review fixes at their owning layer. Original layer head: 5e78b22 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-platform-startup
branch
from
October 30, 2026 23:48
2e45b1c to
1e0b6fb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #888; its review history remains there.
Summary
Validation
At
5e78b226300e72aa68293d989bbcc112715d1bdbon 2026-10-30:cargo fmt -- --check: passed.-D warnings): passed withgrpc-preview,dangerous-options,trident_api/documentation,functional-test,pytest-generator.functional-test.Stack
Native stack 913, position 6/20. Positions 1-14 provide sink-neutral telemetry; positions 15-20 add telemetry preferences, shared transport, AppInsights and build/image/package integration.
Full-stack pipeline branch:
user/bfjelds/telemetry-default-optin(#910).Related PRs in stack: