[bfjelds (bfjelds)]

Summary

• Default missing agent configuration or an unset Telemetry setting to OptIn; preserve explicit OptOut and malformed-value fail-closed behavior.
• Add trident-telemetry-optout: install/upgrade sets OptOut while preserving other settings; uninstall leaves the opt-out configuration intact.

Validation

At b5eb99c180f9289dca716a143d0ea5504d3efeec on 2026-10-30:

• cargo fmt -- --check: passed.
• All-target compilation and strict Clippy (-D warnings): passed with grpc-preview,dangerous-options,trident_api/documentation,functional-test,pytest-generator.
• Focused host-safe unit tests: passed without enabling functional-test.
• Targeted daemon and gRPC-client unit tests: passed.
• Binary pre-reboot flush regression: passed.
• VM functional tests were not run as part of this local validation. No CI result is asserted here.

Prior packaging checks (2026-10-29, before the exact-tree-preserving reorder): RPM spec parsing, an opt-out RPM build using cached Trident binaries, and seven --nodeps RPM transaction scenarios passed. The source Cargo build was skipped in that packaging validation copy. Full source rebuild, dependency-solver validation, VM lifecycle tests and live ingestion were not performed.

Stack

Native stack 913, position 20/20. Positions 1-14 provide sink-neutral telemetry; positions 15-20 add telemetry preferences, shared transport, AppInsights and build/image/package integration.

Full-stack pipeline branch: user/bfjelds/telemetry-default-optin (#910).

Related PRs in stack:

• telemetry [1]: add generic key-value storage to datastore #773
• telemetry [2]: introduce typed command classification #880
• telemetry [3]: correlate commands with operation context #881
• telemetry [4]: persist and attach installation IDs #882
• telemetry [5]: correlate staged servicing operations #883
• telemetry [6]: enrich platform and startup metrics #912
• telemetry [7]: report effective servicing feature usage #889
• telemetry [8]: preserve local metrics and bound TraceStream requests #890
• telemetry [9]: introduce command error reporting helpers #778
• telemetry [10]: report CLI and reboot command failures #891
• telemetry [11]: report daemon dispatch and request errors #892
• telemetry [12]: report gRPC client transport failures #893
• telemetry [13]: complete servicing outcome metrics #894
• telemetry [14]: remove asset_id #779
• telemetry [15]: add agent configuration opt-in #884
• telemetry [16]: share background upload transport #885
• telemetry [17]: send metrics to Application Insights #774
• telemetry [18]: configure telemetry ingestion destinations #886
• telemetry [19]: enable Telemetry=OptIn by default for test/dev images #781
• [this PR] telemetry [20]: default to OptIn and add opt-out RPM #910

[azure-pipelines]

Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

🟡 Changes recommended

Ignoring all configuration read errors can leave telemetry enabled despite an explicit opt-out when the file contains invalid UTF-8.

1 open issue

• Disable telemetry when existing configuration cannot be read · New

What changed in this PR

Changes Trident telemetry to default to OptIn and adds an RPM-based opt-out that preserves other agent settings.

Changes:

• Default missing telemetry configuration to OptIn and extend configuration tests.
• Add trident-telemetry-optout, which writes a persistent opt-out on installation or upgrade.
• Update configuration documentation and startup status text to reflect the new default.

File	Description
packaging/​rpm/​trident.spec	Adds the opt-out subpackage and configuration script.
docs/​Reference/​Telemetry.md	Documents default-enabled telemetry and opt-out options.
docs/​Reference/​Agent-Configuration.md	Explains defaults, RPM behavior, and when changes take effect.
crates/​trident/​src/​main.rs	Removes outdated default-opt-out wording from status text and comments.
crates/​trident/​src/​agentconfig.rs	Changes the telemetry default and adds unset-configuration tests.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues were identified for the telemetry default and opt-out packaging changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are identified for the telemetry-default and persistent opt-out changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues remain for the telemetry-default and opt-out packaging changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are reported for the telemetry-default and opt-out changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues block approval of the telemetry default and opt-out changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues were identified for the telemetry default and opt-out package changes.

No open issues 🎉

_{Review effort: Balanced}