Repository navigation
telemetry [6]: add agent configuration opt-in - #884
Draft
bfjelds (bfjelds) wants to merge 3 commits into
Draft
bfjelds (bfjelds) wants to merge 3 commits into
bfjelds (bfjelds) wants to merge 3 commits into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 25, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new telemetry documentation link targets a missing page, which the website’s strict broken-link checks reject.
1 open issue
What changed in this PR
This PR adds default-off telemetry configuration as groundwork for the telemetry stack and preserves existing agent settings when adding a custom datastore path.
Changes:
- Adds case-insensitive telemetry opt-in parsing and unit tests.
- Preserves existing configuration through atomic writes while retaining root-verity restrictions.
- Adds a build-time connection-string constant and documents telemetry configuration.
| File | Description |
|---|---|
| docs/Reference/Agent-Configuration.md | Documents telemetry opt-in and build-time requirements. |
| crates/trident/src/subsystems/management.rs | Preserves existing settings when adding DatastorePath, with regression tests. |
| crates/trident/src/lib.rs | Exposes the compiled-in telemetry connection string. |
| crates/trident/src/agentconfig.rs | Parses telemetry preferences, defaults to disabled, and adds tests. |
| crates/trident/build.rs | Tracks connection-string environment changes for rebuilds. |
Review effort: Balanced
This was referenced Oct 26, 2026
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-agent-config
branch
from
October 26, 2026 01:33
0a9c312 to
09320cb
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped configuration changes have no unresolved blocking findings and include targeted regression tests; tests were not run in this review environment.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
bfjelds (bfjelds)
changed the title
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-agent-config
branch
from
October 26, 2026 01:53
09320cb to
3965bad
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-agent-config
branch
from
October 28, 2026 00:06
3965bad to
392b1c4
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0e7cadc-8f44-443f-affe-6ce8e856a218 Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-agent-config
branch
from
October 28, 2026 20:45
392b1c4 to
ebc7397
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add default-off telemetry configuration and preserve existing configuration when adding DatastorePath.
Related PRs in stack: