Repository navigation
telemetry [4]: persist and attach installation IDs - #882
Draft
bfjelds (bfjelds) wants to merge 2 commits into
Draft
bfjelds (bfjelds) wants to merge 2 commits into
bfjelds (bfjelds) wants to merge 2 commits into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 25, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Multiboot datastore reuse and the unconditional operation-ID fallback can attribute telemetry to the wrong installation.
2 open issues
What changed in this PR
Adds persistent installation IDs to Trident’s telemetry, building on datastore key-value storage and operation context to correlate activity across commands and reboots.
Changes:
- Stores stable installation IDs with legacy-datastore migration.
- Attaches IDs through CLI, daemon, install, and bootstrap paths, with deferred attachment for multiboot.
- Adds persistence, concurrency, and telemetry serialization tests.
| File | Description |
|---|---|
| crates/trident/src/server/tridentserver/mod.rs | Refreshes IDs before servicing-request telemetry. |
| crates/trident/src/server/mod.rs | Attaches existing IDs at daemon startup. |
| crates/trident/src/main.rs | Preloads IDs and defers multiboot attachment. |
| crates/trident/src/logging/tracestream.rs | Shares and emits installation IDs; adds attachment tests. |
| crates/trident/src/lib.rs | Integrates ID creation with installation and bootstrap workflows. |
| crates/trident/src/datastore.rs | Adds ID storage, migration, and stability tests. |
Review effort: Balanced
This was referenced Oct 26, 2026
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-installation-id
branch
from
October 26, 2026 01:33
367edbd to
44ebea1
Compare
bfjelds (bfjelds)
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0e7cadc-8f44-443f-affe-6ce8e856a218
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-installation-id
branch
from
October 26, 2026 01:53
44ebea1 to
248fafa
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Human assessment is needed because streaming can report an installation ID that is not persisted on the deployed host, breaking telemetry correlation after boot.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist stable installation IDs, including legacy migration and multiboot handling.
Related PRs in stack: