Repository navigation
telemetry [5]: correlate staged servicing operations - #883
Draft
bfjelds (bfjelds) wants to merge 3 commits into
Draft
bfjelds (bfjelds) wants to merge 3 commits into
bfjelds (bfjelds) wants to merge 3 commits into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 25, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Multiboot finalize-only startup telemetry can inherit an unrelated servicing ID before the correct datastore is selected.
1 open issue
What changed in this PR
This PR extends telemetry correlation by persisting a servicing ID shared across staging, finalize, and commit invocations.
Changes:
- Store and recover servicing IDs through the datastore’s key-value API.
- Attach servicing IDs to trace events and refresh them during servicing commands.
- Add regression tests for ID replacement, stale-ID overrides, and cross-invocation recovery.
| File | Description |
|---|---|
crates/trident/src/logging/tracestream.rs |
Attach servicing IDs to telemetry and test correlation behavior. |
crates/trident/src/lib.rs |
Refresh servicing IDs for install, update, rollback, and commit. |
crates/trident/src/datastore.rs |
Persist and retrieve the current servicing ID. |
Review effort: Balanced
This was referenced Oct 26, 2026
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-servicing-id
branch
from
October 26, 2026 01:33
6fa7894 to
3aadb8d
Compare
bfjelds (bfjelds)
changed the title
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-servicing-id
branch
from
October 26, 2026 01:53
3aadb8d to
a601466
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0e7cadc-8f44-443f-affe-6ce8e856a218 Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-servicing-id
branch
from
October 28, 2026 00:06
a601466 to
93b1fcf
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist staging IDs, recover them for finalize/commit, and prevent stale attribution.
Related PRs in stack: