Repository navigation
telemetry [18]: configure telemetry ingestion destinations - #886
Draft
bfjelds (bfjelds) wants to merge 1 commit into
Draft
bfjelds (bfjelds) wants to merge 1 commit into
bfjelds (bfjelds) wants to merge 1 commit into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 25, 2026
This was referenced Oct 26, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
RPM handling of Docker’s empty default connection string remains unvalidated and needs confirmation before approval.
No open issues 🎉
What changed in this PR
This PR wires build-time telemetry destinations into Trident’s existing telemetry support, separating CI-built artifacts from Azure Linux distro packages.
Changes:
- Pass the CI telemetry connection string through Docker to RPM builds.
- Configure a separate destination for distro builds.
- Preserve an empty connection string when the optional repo-build RPM macro is absent.
| File | Description |
|---|---|
packaging/rpm/trident.spec |
Selects and exports the build-time telemetry connection string. |
packaging/docker/Dockerfile.full |
Forwards the connection string as an RPM macro. |
.pipelines/templates/stages/trident_rpms/release.yml |
Supplies the CI telemetry destination to Docker builds. |
Review effort: Balanced
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-connection-strings
branch
from
October 26, 2026 01:33
ff6638c to
1092d40
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-connection-strings
branch
from
October 30, 2026 18:52
423f75d to
260261c
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-connection-strings
branch
from
October 30, 2026 19:25
260261c to
78dd3f6
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-connection-strings
branch
from
October 30, 2026 19:51
78dd3f6 to
15b3f7c
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-connection-strings
branch
from
October 30, 2026 20:14
15b3f7c to
3e43a9a
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-connection-strings
branch
2 times, most recently
from
October 30, 2026 22:02
8f78bad to
e617c47
Compare
Rebase onto agent configuration read-error handling. Original layer head: 8be95ef Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
At
8be95efefec3a13e8dcca8ca736d145355265a00on 2026-10-30:cargo fmt -- --check: passed.-D warnings): passed withgrpc-preview,dangerous-options,trident_api/documentation,functional-test,pytest-generator.functional-test.Stack
Native stack 913, position 18/20. Positions 1-14 provide sink-neutral telemetry; positions 15-20 add telemetry preferences, shared transport, AppInsights and build/image/package integration.
Full-stack pipeline branch:
user/bfjelds/telemetry-default-optin(#910).Related PRs in stack: