[bfjelds (bfjelds)]

Description

Add VM, architecture, and ACL fields; report boot uptime on trident_start using shared hypervisor detection.

Rationale

Extracted from #778 to make the telemetry stack easier to review. Combined changes are unchanged.

Validation

Source	Command or check	Result	Notes
Agent	cargo test --locked --manifest-path /home/bfjelds/mjolnir-sandbox/trident-telemetry-split778-20261025-1743/Cargo.toml -p trident -p osutils -p trident_api --features trident/grpc-preview,trident/dangerous-options,trident_api/documentation -- command_kind:: logging:: cli:: engine::context:: config::host::tests virt::	Passed	103 targeted unit tests; run from /home/bfjelds/mjolnir-sandbox.
Agent	Git tree comparison	Passed	Final split tip exactly matches original #778; restacked #779/#781 trees unchanged.
Agent	cargo test --locked --manifest-path /home/bfjelds/mjolnir-sandbox/trident-telemetry-split778-20261025-1743/Cargo.toml -p trident -p osutils -p trident_api --features trident/grpc-preview,trident/dangerous-options -- command_kind:: logging:: cli:: engine::context:: config::host::tests virt::	Failed	Resolved: API unit tests require the existing documentation feature; corrected command above passed without source changes.
Agent	VM functional tests	Not run	Require a VM; only host-safe unit tests were run.
CI	Pipeline checks	Not run	Not evaluated as part of this split; results above are local.

Related PRs in stack:

• telemetry [1]: add generic key-value storage to datastore #773
• telemetry [2]: introduce typed command classification #880
• telemetry [3]: correlate commands with operation context #881
• telemetry [4]: persist and attach installation IDs #882
• telemetry [5]: correlate staged servicing operations #883
• telemetry [15]: add agent configuration opt-in #884
• telemetry [16]: share background upload transport #885
• telemetry [17]: send metrics to Application Insights #774
• telemetry [18]: configure telemetry ingestion destinations #886
• [this PR] telemetry [10]: enrich platform and startup metrics #888
• telemetry [7]: report effective servicing feature usage #889
• telemetry [8]: preserve local metrics and bound TraceStream requests #890
• telemetry [9]: introduce command error reporting helpers #778
• telemetry [10]: report CLI and reboot command failures #891
• telemetry [11]: report daemon dispatch and request errors #892
• telemetry [12]: report gRPC client transport failures #893
• telemetry [13]: complete servicing outcome metrics #894
• telemetry [14]: remove asset_id #779
• telemetry [19]: enable Telemetry=OptIn by default for test/dev images #781

[azure-pipelines]

Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

🟢 Approval recommended

Review found no blocking issues in the metadata enrichment, best-effort uptime reporting, or behavior-preserving detection extraction.

No open issues 🎉

What changed in this PR

This PR extends Trident’s telemetry with host platform details and boot uptime, while sharing hypervisor detection with diagnostics.

Changes:

• Add VM status, CPU architecture, and Azure Container Linux detection to platform metadata.
• Report boot uptime on trident_start, with regression coverage for unavailable clock data.
• Extract existing hypervisor detection into osutils and document the new telemetry fields.

File	Description
docs/​Reference/​Telemetry.md	Document platform fields and detection limitations.
crates/​trident/​src/​logging/​tracestream.rs	Populate platform metadata and add uptime conversion coverage.
crates/​trident/​src/​lib.rs	Attach boot uptime to the startup metric.
crates/​trident/​src/​diagnostics.rs	Reuse shared hypervisor detection.
crates/​osutils/​src/​virt.rs	Provide shared hypervisor and VM detection helpers.
Cargo.toml	Enable the nix time feature for clock access.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

The changes preserve diagnostic detection behavior and keep telemetry failures best-effort, with no identified blocking issues.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

The changes are additive, preserve existing diagnostic detection behavior, and keep telemetry collection best-effort, with no unresolved blocking findings.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

The additive telemetry changes preserve diagnostic detection behavior and handle collection failures without introducing any identified blocking issues.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are reported for the telemetry metadata and boot-uptime changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are identified in the supplied review evidence.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues block approval of the telemetry and shared hypervisor-detection changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues were identified for the telemetry enhancements and shared virtualization detection changes.

No open issues 🎉

_{Review effort: Balanced}