[bfjelds (bfjelds)]

Description

Correlate gRPC-client commands and report transport failures without double-counting daemon errors; update telemetry docs.

Document that busy-lock and unprovisioned-host admission-control rejections intentionally emit no command_error from either daemon or client; runtime behavior is unchanged.

Rationale

Extracted from #778 to make the telemetry stack easier to review. Combined changes are unchanged.

Validation

Source	Command or check	Result	Notes
Agent (2026-10-27)	git diff --check 837f40d5648465449de4f32333d269721ddbe77c 34025733f8bcb43940fa13a7cafdc476586b384d	Passed	Admission-control documentation correction only; runtime trees unchanged.
Agent (2026-10-27)	Exact-tree comparison; 19-PR ancestry, base, native-stack and mergeability checks	Passed	Each affected tree is its original plus the documentation patch. All 19 PRs remain in stack 895; the final branch contains the entire stack.
Agent	cargo test --locked --manifest-path /home/bfjelds/mjolnir-sandbox/trident-telemetry-split778-20261025-1743/Cargo.toml -p trident -p osutils -p trident_api --features trident/grpc-preview,trident/dangerous-options,trident_api/documentation -- command_kind:: logging:: cli:: engine::context:: config::host::tests virt::	Passed	115 targeted unit tests; run from /home/bfjelds/mjolnir-sandbox.
Agent	Git tree comparison	Passed	Final split tip exactly matches original #778; restacked #779/#781 trees unchanged.
Agent	VM functional tests	Not run	Require a VM; only host-safe unit tests were run.
CI	Pipeline checks	Not run	Not evaluated as part of this split; results above are local.

Related PRs in stack:

• telemetry [1]: add generic key-value storage to datastore #773
• telemetry [2]: introduce typed command classification #880
• telemetry [3]: correlate commands with operation context #881
• telemetry [4]: persist and attach installation IDs #882
• telemetry [5]: correlate staged servicing operations #883
• telemetry [6]: add agent configuration opt-in #884
• telemetry [7]: share background upload transport #885
• telemetry [8]: send metrics to Application Insights #774
• telemetry [9]: configure telemetry ingestion destinations #886
• telemetry [10]: enrich platform and startup metrics #888
• telemetry [11]: report effective servicing feature usage #889
• telemetry [12]: preserve local metrics and bound TraceStream requests #890
• telemetry [13]: introduce command error reporting helpers #778
• telemetry [14]: report CLI and reboot command failures #891
• telemetry [15]: report daemon dispatch and request errors #892
• [this PR] telemetry [16]: report gRPC client transport failures #893
• telemetry [17]: complete servicing outcome metrics #894
• telemetry [18]: remove asset_id #779
• telemetry [19]: enable Telemetry=OptIn by default for test/dev images #781

[azure-pipelines]

Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

🟡 Changes recommended

Client telemetry incorrectly synthesizes servicing IDs that do not correlate with the daemon’s persisted servicing identity.

1 open issue

• Avoid synthesizing servicing IDs for GrpcClient events · New

What changed in this PR

Extends the telemetry stack to correlate gRPC-client commands and report transport failures while avoiding duplicate reports of daemon errors.

Changes:

• Wraps client dispatch in command context and selectively reports servicing transport failures.
• Filters busy-daemon responses out of client error telemetry.
• Updates documentation for client correlation IDs and command-error reporting.

File	Description
docs/​Reference/​Telemetry.md	Documents client correlation fields and error-reporting behavior.
crates/​trident/​src/​logging/​operation_context.rs	Updates module documentation for client context wiring.
crates/​trident/​src/​grpc_client/​mod.rs	Adds correlated dispatch and transport-error filtering.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The telemetry documentation incorrectly promises command_error reporting for busy-lock and unprovisioned-host rejections, which neither the server nor client reports.

1 open issue

• Document unreported admission-control command rejections · New

1 resolved since last review

• Detect all transport failures in servicing response streams

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are recorded for the telemetry correlation and transport-error reporting changes.

No open issues 🎉

1 resolved since last review

• Document unreported admission-control command rejections

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

The client telemetry and transport-failure reporting changes have no active review issues.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues block the client telemetry correlation and transport-failure reporting changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues block approval of the telemetry correlation and transport-failure reporting changes.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues remain for the gRPC client command-error telemetry changes.

No open issues 🎉

_{Review effort: Balanced}