Repository navigation
telemetry [11]: report effective servicing feature usage - #889
Draft
bfjelds (bfjelds) wants to merge 1 commit into
Draft
bfjelds (bfjelds) wants to merge 1 commit into
bfjelds (bfjelds) wants to merge 1 commit into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 26, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The blanket default-value fallback reports removed extensions and omitted scripts as active features.
1 open issue
What changed in this PR
Moves feature-usage telemetry into EngineContext so install and update metrics can consider both current and prior configuration.
Changes:
- Emits feature metrics during clean-install staging and updates that require staging.
- Adds default-value fallback to prior configuration, while keeping internal parameters invocation-specific.
- Relocates telemetry tests and adds update fallback coverage.
| File | Description |
|---|---|
crates/trident/src/lib.rs |
Removes startup-time feature tracing. |
crates/trident/src/engine/update.rs |
Emits feature metrics after selecting the servicing type. |
crates/trident/src/engine/context/mod.rs |
Adds context-based feature tracing and tests. |
crates/trident/src/engine/clean_install.rs |
Emits feature metrics during install staging. |
crates/trident_api/src/config/host/mod.rs |
Removes configuration-owned telemetry and its tests. |
Review effort: Balanced
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-effective-features
branch
from
October 26, 2026 01:33
7d1fadb to
4fc7fc6
Compare
bfjelds (bfjelds)
changed the title
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-effective-features
branch
from
October 26, 2026 01:53
4fc7fc6 to
eeb442d
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-effective-features
branch
from
October 26, 2026 03:15
eeb442d to
9c3af7e
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-effective-features
branch
from
October 28, 2026 00:06
9c3af7e to
44454a5
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-effective-features
branch
from
October 28, 2026 20:45
44454a5 to
d66b6a6
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-effective-features
branch
from
October 28, 2026 21:58
d66b6a6 to
bc1eb7d
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0e7cadc-8f44-443f-affe-6ce8e856a218 Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-effective-features
branch
from
October 28, 2026 22:58
bc1eb7d to
9eac5d6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trace current install/update features from EngineContext without treating default values as unspecified or reviving removed features.
Rationale
Extracted from #778 to make the telemetry stack easier to review. Follow-up review fixes align feature telemetry with the current servicing specification.
Validation
Follow-up: 16 EngineContext unit tests passed on the revised layer. The original split checks below predate these fixes.
cargo test --locked --manifest-path /home/bfjelds/mjolnir-sandbox/trident-telemetry-split778-20261025-1743/Cargo.toml -p trident -p osutils -p trident_api --features trident/grpc-preview,trident/dangerous-options,trident_api/documentation -- command_kind:: logging:: cli:: engine::context:: config::host::tests virt::/home/bfjelds/mjolnir-sandbox.Related PRs in stack: