Repository navigation
telemetry [15]: report daemon dispatch and request errors - #892
Draft
bfjelds (bfjelds) wants to merge 2 commits into
Draft
bfjelds (bfjelds) wants to merge 2 commits into
bfjelds (bfjelds) wants to merge 2 commits into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 26, 2026
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-daemon-request-errors
branch
from
October 26, 2026 01:33
a9086d9 to
6e0e24a
Compare
bfjelds (bfjelds)
changed the title
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the reporting changes or preservation of existing response behavior and telemetry exclusions.
No open issues 🎉
What changed in this PR
Extends the telemetry stack’s command-error reporting to daemon dispatch and malformed servicing requests, while preserving existing gRPC responses and excluding read-only requests and busy-lock rejections.
Changes:
- Wraps servicing dispatch in correlated command-error reporting.
- Adds structured errors and telemetry helpers for missing or invalid request fields.
- Centralizes busy-response messages and documents intentional telemetry exclusions.
| File | Description |
|---|---|
crates/trident/src/server/tridentserver/services/validation.rs |
Documents why validation rejections remain untelemetered. |
crates/trident/src/server/tridentserver/services/update.rs |
Reports missing update request fields. |
crates/trident/src/server/tridentserver/services/streaming.rs |
Reports invalid image URLs with structured error details. |
crates/trident/src/server/tridentserver/services/rollback.rs |
Reports missing rollback configurations. |
crates/trident/src/server/tridentserver/services/mod.rs |
Adds shared malformed-request reporting helpers. |
crates/trident/src/server/tridentserver/services/install.rs |
Reports missing install request fields. |
crates/trident/src/server/tridentserver/mod.rs |
Enables dispatch error reporting while preserving telemetry exclusions. |
crates/trident/src/logging/operation_context.rs |
Defines shared busy-lock response messages. |
crates/trident_api/src/error.rs |
Adds structured missing-field and invalid-field errors. |
Review effort: Balanced
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-daemon-request-errors
branch
from
October 26, 2026 01:53
6e0e24a to
ed0fe6b
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-daemon-request-errors
branch
from
October 26, 2026 03:15
ed0fe6b to
c503ca3
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-daemon-request-errors
branch
from
October 26, 2026 15:10
c503ca3 to
73c1b9f
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-daemon-request-errors
branch
from
October 28, 2026 00:06
73c1b9f to
1220898
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-daemon-request-errors
branch
from
October 28, 2026 20:45
1220898 to
cb62f43
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-daemon-request-errors
branch
from
October 28, 2026 21:58
cb62f43 to
9b375f4
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0e7cadc-8f44-443f-affe-6ce8e856a218 Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-daemon-request-errors
branch
from
October 28, 2026 22:58
9b375f4 to
9dce2ee
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Report servicing dispatch and malformed-request failures with structured fields; keep read-only and busy-lock rejections untelemetered.
Rationale
Extracted from #778 to make the telemetry stack easier to review. Combined changes are unchanged.
Validation
cargo test --locked --manifest-path /home/bfjelds/mjolnir-sandbox/trident-telemetry-split778-20261025-1743/Cargo.toml -p trident -p osutils -p trident_api --features trident/grpc-preview,trident/dangerous-options,trident_api/documentation -- command_kind:: logging:: cli:: engine::context:: config::host::tests virt::/home/bfjelds/mjolnir-sandbox.Related PRs in stack: