Repository navigation
telemetry [14]: report CLI and reboot command failures - #891
Draft
bfjelds (bfjelds) wants to merge 3 commits into
Draft
bfjelds (bfjelds) wants to merge 3 commits into
bfjelds (bfjelds) wants to merge 3 commits into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 26, 2026
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-cli-command-errors
branch
from
October 26, 2026 01:33
cbd7b3b to
95fdfb5
Compare
bfjelds (bfjelds)
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
CLI reboot failure events are emitted after telemetry shutdown, preventing delivery to Application Insights.
1 open issue
What changed in this PR
Extends the command-error helpers from #778 to Trident’s CLI servicing and CLI/daemon reboot paths, aiming to preserve existing exit behavior.
Changes:
- Wraps servicing and reboot operations in correlated error reporting.
- Adds a parse-only Host Configuration file helper.
- Updates operation-context exports and explanatory comments.
| File | Description |
|---|---|
crates/trident/src/validation.rs |
Adds a parse-only configuration file helper. |
crates/trident/src/server/mod.rs |
Reports structured daemon reboot failures. |
crates/trident/src/main.rs |
Integrates CLI servicing and reboot error reporting. |
crates/trident/src/lib.rs |
Removes the run_with_operation re-export. |
Review effort: Balanced
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-cli-command-errors
branch
from
October 26, 2026 01:53
95fdfb5 to
04e816b
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-cli-command-errors
branch
from
October 26, 2026 03:15
04e816b to
f015992
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-cli-command-errors
branch
from
October 26, 2026 15:10
f015992 to
67ee2dc
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-cli-command-errors
branch
from
October 28, 2026 00:06
67ee2dc to
b27ff2c
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-cli-command-errors
branch
from
October 28, 2026 20:45
b27ff2c to
91f9454
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-cli-command-errors
branch
from
October 28, 2026 21:58
91f9454 to
2e87e6d
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0e7cadc-8f44-443f-affe-6ce8e856a218 Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-cli-command-errors
branch
from
October 28, 2026 22:58
2e87e6d to
8e0a9a3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrap CLI servicing and CLI/daemon reboot paths in command-error reporting; retain existing exit behavior.
Rationale
Extracted from #778 to make the telemetry stack easier to review. Combined changes are unchanged.
Validation
cargo test --locked --manifest-path /home/bfjelds/mjolnir-sandbox/trident-telemetry-split778-20261025-1743/Cargo.toml -p trident -p osutils -p trident_api --features trident/grpc-preview,trident/dangerous-options,trident_api/documentation -- command_kind:: logging:: cli:: engine::context:: config::host::tests virt::/home/bfjelds/mjolnir-sandbox.Related PRs in stack: