Repository navigation
telemetry [2]: introduce typed command classification - #880
Draft
bfjelds (bfjelds) wants to merge 1 commit into
Draft
bfjelds (bfjelds) wants to merge 1 commit into
bfjelds (bfjelds) wants to merge 1 commit into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 25, 2026
bfjelds (bfjelds)
changed the title
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues in the typed mappings, phase naming, or datastore admission changes.
No open issues 🎉
What changed in this PR
Introduces typed command classification shared by the CLI, gRPC client, and daemon, laying groundwork for command-correlated telemetry in the broader stack.
Changes:
- Adds
CommandKind, phase-aware naming, and classification tests. - Replaces daemon servicing-request name strings with typed constructors.
- Uses shared classification for CLI and daemon datastore admission checks.
| File | Description |
|---|---|
crates/trident/src/server/tridentserver/services/update.rs |
Uses typed update command variants. |
crates/trident/src/server/tridentserver/services/streaming.rs |
Uses typed disk-streaming classification. |
crates/trident/src/server/tridentserver/services/rollback.rs |
Uses typed rollback command variants. |
crates/trident/src/server/tridentserver/services/rebuild_raid.rs |
Uses typed RAID rebuild classification. |
crates/trident/src/server/tridentserver/services/install.rs |
Uses typed install command variants. |
crates/trident/src/server/tridentserver/services/commit.rs |
Classifies commit and check-root requests. |
crates/trident/src/server/tridentserver/mod.rs |
Accepts typed requests and checks datastore admission. |
crates/trident/src/main.rs |
Applies shared datastore admission classification. |
crates/trident/src/logging/operation_context.rs |
Adds phase-aware command naming. |
crates/trident/src/logging/mod.rs |
Registers the operation-context module. |
crates/trident/src/lib.rs |
Registers the command-classification module. |
crates/trident/src/command_kind.rs |
Defines command mappings, predicates, constructors, and tests. |
Review effort: Balanced
This was referenced Oct 26, 2026
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-command-kind
branch
from
October 26, 2026 01:33
26e4e79 to
d0d148c
Compare
bfjelds (bfjelds)
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0e7cadc-8f44-443f-affe-6ce8e856a218
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/mjolnir/telemetry-command-kind
branch
from
October 26, 2026 01:53
d0d148c to
6c6ee5c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CommandKind and shared phase naming; use typed CLI and daemon datastore admission.
Related PRs in stack: