telemetry [19]: enable Telemetry=OptIn by default for test/dev images by bfjelds · Pull Request #781 · microsoft/trident

bfjelds (bfjelds) · 2026-09-07T17:51:19Z

Enable telemetry for test pipelines by adding trident.conf with Telemetry=OptIn to test images.

Related PRs in stack:

azure-pipelines · 2026-09-07T17:51:28Z

Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

🟢 Approval recommended

The manifests consistently reference the valid shared opt-in configuration at the expected agent configuration path.

Pull request overview

Adds a shared telemetry opt-in configuration to test and development images.

Changes:

Adds Telemetry=OptIn to a shared trident.conf.
Installs the configuration across test, installer, container, VM, and verity images.

File summaries

File	Description
`tests/images/common/trident.conf`	Defines telemetry opt-in.
`tests/images/trident-vm-testimage/base/updateimg-grub.yaml`	Installs shared configuration.
`tests/images/trident-vm-testimage/base/updateimg-grub-verity.yaml`	Installs shared configuration.
`tests/images/trident-vm-testimage/base/updateimg-grub-verity-azure.yaml`	Installs shared configuration.
`tests/images/trident-vm-testimage/base/baseimg-usr-verity.yaml`	Installs shared configuration.
`tests/images/trident-vm-testimage/base/baseimg-root-verity.yaml`	Installs shared configuration.
`tests/images/trident-vm-testimage/base/baseimg-grub.yaml`	Installs shared configuration.
`tests/images/trident-vm-testimage/base/baseimg-grub-verity.yaml`	Installs shared configuration.
`tests/images/trident-vm-testimage/base/baseimg-grub-verity-azure.yaml`	Installs shared configuration.
`tests/images/trident-verity-testimage/usr/host.yaml`	Installs shared configuration.
`tests/images/trident-verity-testimage/usr/container.yaml`	Installs shared configuration.
`tests/images/trident-verity-testimage/base/baseimg.yaml`	Installs shared configuration.
`tests/images/trident-verity-testimage/base/baseimg-container.yaml`	Installs shared configuration.
`tests/images/trident-testimage/base/baseimg.yaml`	Installs shared configuration.
`tests/images/trident-mos/iso.yaml`	Installs shared configuration.
`tests/images/trident-mos/containerhost-iso.yaml`	Installs shared configuration.
`tests/images/trident-installer/base/baseimg.yaml`	Installs shared configuration.
`tests/images/trident-installer/base/baseimg-split.yaml`	Installs shared configuration.
`tests/images/trident-installer/base/baseimg-direct-streaming.yaml`	Installs shared configuration.
`tests/images/trident-functest/base/baseimg.yaml`	Adds and installs the configuration.
`tests/images/trident-container-testimage/base/baseimg.yaml`	Installs shared configuration.
`tests/images/trident-container-installer/base/baseimg.yaml`	Installs shared configuration.
`tests/images/azurelinux-direct-streaming-testimage/base/baseimg.yaml`	Adds and installs the configuration.
`tests/images/azl-installer/installer-iso.yaml`	Installs shared configuration.

Review details

Files reviewed: 24/24 changed files
Comments generated: 0
Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

🟢 Approval recommended

The configuration matches Trident’s parser and expected path, and all manifest source references resolve correctly.

Review details

Files reviewed: 24/24 changed files
Comments generated: 0 new
Review effort level: Balanced

Copilot

Copilot review overview

🟡 Changes recommended

The two ACL-agent test image configurations still default to telemetry opt-out.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

Enable telemetry opt-in in Trident ACL-agent test images · New

Copilot

Copilot review overview

🟢 Approval recommended

The inline configuration is valid, consistently applied, and avoids the previously identified shared-file dependency issue.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Enable telemetry opt-in in Trident ACL-agent test images

Copilot

🟢 Approval recommended

The configuration-only changes align with existing parsing and container mounts, with no unresolved blocking issues; image builds were not run.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

The changes consistently use the supported opt-in setting and configuration path, with no unresolved blocking issues.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

The changes are scoped configuration additions compatible with existing telemetry loading, and no blocking issues remain.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

The configuration-only additions match the existing telemetry contract and container mounts, with no unresolved blocking issues identified.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

The scoped configuration additions match the existing opt-in contract, address prior feedback, and have no identified blocking issues.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

The changes consistently use the supported opt-in setting and configuration path, with no unresolved blocking issues.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

The scoped manifest additions use the supported configuration format and path, resolve prior feedback, and have no unresolved blocking issues.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

The configuration-only changes match the existing opt-in parser and inspected container mounts, with no unresolved blocking issues found in static review.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

No active review issues are reported for the test-image telemetry opt-in changes.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

No active review issues remain for the changes enabling telemetry in test and development images.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

No active review issues are recorded for the telemetry opt-in changes to test and development images.

No open issues 🎉

_{Review effort: Balanced}

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0e7cadc-8f44-443f-affe-6ce8e856a218 Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11

Copilot

🟢 Approval recommended

No active review issues block the test-image telemetry opt-in rollout.

No open issues 🎉

_{Review effort: Balanced}

bfjelds (bfjelds) requested a review from a team as a code owner September 7, 2026 17:51

bfjelds (bfjelds) changed the title ~~tests/images: enable Telemetry=OptIn by default for test/dev images~~ telemetry: enable Telemetry=OptIn by default for test/dev images Sep 7, 2026

This was referenced Sep 7, 2026

telemetry [18]: remove asset_id #779

Open

telemetry [13]: introduce command error reporting helpers #778

Open

telemetry [8]: send metrics to Application Insights #774

Open

telemetry [1]: add generic key-value storage to datastore #773

Open

bfjelds (bfjelds) force-pushed the user/bfjelds/mjolnir/testimages-telemetry-optin branch from 1f21c48 to 3113a53 Compare September 7, 2026 18:46

bfjelds (bfjelds) force-pushed the user/bfjelds/mjolnir/testimages-telemetry-optin branch from 3113a53 to 9c5f25f Compare September 7, 2026 18:51

bfjelds (bfjelds) force-pushed the user/bfjelds/mjolnir/testimages-telemetry-optin branch from 9c5f25f to 8481006 Compare September 7, 2026 19:07

bfjelds (bfjelds) force-pushed the user/bfjelds/mjolnir/testimages-telemetry-optin branch from 8481006 to fe8ca7b Compare September 7, 2026 21:17

bfjelds (bfjelds) force-pushed the user/bfjelds/mjolnir/testimages-telemetry-optin branch from fe8ca7b to dbaeaf5 Compare September 7, 2026 22:14

bfjelds (bfjelds) force-pushed the user/bfjelds/mjolnir/testimages-telemetry-optin branch from dbaeaf5 to bb26845 Compare September 7, 2026 22:18

bfjelds (bfjelds) force-pushed the user/bfjelds/mjolnir/testimages-telemetry-optin branch from bb26845 to f2ed3e4 Compare September 7, 2026 22:24

bfjelds (bfjelds) force-pushed the user/bfjelds/mjolnir/testimages-telemetry-optin branch from f2ed3e4 to da85729 Compare September 7, 2026 22:38

bfjelds (bfjelds) requested a balanced review from Copilot September 8, 2026 17:20

Copilot started reviewing on behalf of bfjelds (bfjelds) September 8, 2026 17:21

View session

Copilot AI reviewed Sep 8, 2026

View reviewed changes

bfjelds (bfjelds) requested a balanced review from Copilot September 8, 2026 19:54

Copilot started reviewing on behalf of bfjelds (bfjelds) September 8, 2026 19:55

View session

Copilot AI reviewed Sep 8, 2026

View reviewed changes

bfjelds (bfjelds) requested a balanced review from Copilot September 8, 2026 21:37

Copilot AI reviewed Sep 25, 2026

View reviewed changes

Comment thread tests/images/trident-vm-testimage/base/updateimg-grub.yaml

Copilot AI reviewed Sep 25, 2026

View reviewed changes

Copilot AI reviewed Oct 25, 2026

View reviewed changes

Copilot AI reviewed Oct 26, 2026

View reviewed changes

Copilot AI reviewed Oct 27, 2026

View reviewed changes

Copilot AI reviewed Oct 28, 2026

View reviewed changes

telemetry: opt test and development images in by default

f65c669

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d0e7cadc-8f44-443f-affe-6ce8e856a218 Copilot-Session: 43cb811b-f191-4d90-852f-e3373041ca11

Copilot AI reviewed Oct 28, 2026

View reviewed changes

bfjelds (bfjelds) mentioned this pull request Oct 29, 2026

telemetry [20]: default to OptIn and add opt-out RPM #910

Draft

Conversation

bfjelds (bfjelds) commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Sep 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

bfjelds (bfjelds) commented Sep 7, 2026 •

edited

Loading